Re: [PATCH v4 6/8] scsi: ufs: Add dev ref clock gating wait time support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Can Guo <cang@xxxxxxxxxxxxxx>, asutoshd@xxxxxxxxxxxxxx, nguyenb@xxxxxxxxxxxxxx, hongwus@xxxxxxxxxxxxxx, rnayak@xxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, kernel-team@xxxxxxxxxxx, saravanak@xxxxxxxxxx, salyzyn@xxxxxxxxxx
Subject: Re: [PATCH v4 6/8] scsi: ufs: Add dev ref clock gating wait time support
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Sat, 25 Jan 2020 19:34:04 -0800
Cc: Alim Akhtar <alim.akhtar@xxxxxxxxxxx>, Avri Altman <avri.altman@xxxxxxx>, Pedro Sousa <pedrom.sousa@xxxxxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Tomas Winkler <tomas.winkler@xxxxxxxxx>, Stanley Chu <stanley.chu@xxxxxxxxxxxx>, Venkat Gopalakrishnan <venkatg@xxxxxxxxxxxxxx>, open list <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <1579764349-15578-7-git-send-email-cang@codeaurora.org>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 2020-01-22 23:25, Can Guo wrote:
> +	/* getting Specification Version in big endian format */
> +	hba->dev_info.spec_version = desc_buf[DEVICE_DESC_PARAM_SPEC_VER] << 8 |
> +				      desc_buf[DEVICE_DESC_PARAM_SPEC_VER + 1];

Please use get_unaligned_be16() instead of open-coding it.

Thanks,

Bart.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH v4 6/8] scsi: ufs: Add dev ref clock gating wait time support
  - From: Can Guo

References:
- [PATCH v4 0/8] UFS driver general fixes bundle 4
  - From: Can Guo
- [PATCH v4 6/8] scsi: ufs: Add dev ref clock gating wait time support
  - From: Can Guo

Prev by Date: Re: [PATCH v4 1/8] scsi: ufs: Flush exception event before suspend
Next by Date: Re: [PATCH v4 8/8] scsi: ufs: Select INITIAL adapt for HS Gear4
Previous by thread: Re: [PATCH v4 6/8] scsi: ufs: Add dev ref clock gating wait time support
Next by thread: Re: [PATCH v4 6/8] scsi: ufs: Add dev ref clock gating wait time support
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]