On 24/01/2020 16:23, James Bottomley wrote: > On Sat, 2020-01-25 at 00:16 +0900, Johannes Thumshirn wrote: >> If we have an invalid number of entries mapped an sg table, there's >> no need to panic the host, instead we can spit out a warning in dmesg >> and gracefully return an I/O error. > > Can we? This is an assertion failure which should never happen. If it > does, it's likely an indicator that a system has gone seriously out of > spec for some reason, like internal compromise, CPU/Memory failure or > something else. > > The HA view is that panic is appropriate for conditions that should > never happen because it helps the machine fail fast. Yes but an HA setup could still set panic_on_oops and retain the fail fast portion. Anyway it's just something that popped up when I was looking up something unrelated in scsi_lib.c. It's not that I'm married to this cleanup.
