On Wed, Jan 22, 2020 at 08:23:44PM -0800, Bart Van Assche wrote: > This patch allows sparse to verify the endianness of the arguments passed > to MAKE_HANDLE(). > > Cc: Quinn Tran <qutran@xxxxxxxxxxx> > Cc: Martin Wilck <mwilck@xxxxxxxx> > Cc: Daniel Wagner <dwagner@xxxxxxx> > Cc: Roman Bolshakov <r.bolshakov@xxxxxxxxx> > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > --- > drivers/scsi/qla2xxx/qla_def.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h > index b04d334933ef..968f19995063 100644 > --- a/drivers/scsi/qla2xxx/qla_def.h > +++ b/drivers/scsi/qla2xxx/qla_def.h > @@ -119,7 +119,10 @@ typedef struct { > #define LSD(x) ((uint32_t)((uint64_t)(x))) > #define MSD(x) ((uint32_t)((((uint64_t)(x)) >> 16) >> 16)) > > -#define MAKE_HANDLE(x, y) ((uint32_t)((((uint32_t)(x)) << 16) | (uint32_t)(y))) > +static inline uint32_t MAKE_HANDLE(uint16_t x, uint16_t y) > +{ > + return ((uint32_t)x << 16) | y; > +} s/MAKE_HANDLE/make_handle/ ?