Re: [PATCH v4 6/8] scsi: ufs: Delete is_init_prefetch from struct ufs_hba

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/20/2020 5:08 AM, Bean Huo wrote:
From: Bean Huo <beanhuo@xxxxxxxxxx>

Without variable is_init_prefetch, the current logic can guarantee
ufshcd_init_icc_levels() will execute only once, delete it now.

Signed-off-by: Bean Huo <beanhuo@xxxxxxxxxx>
---

Reviewed-by: Asutosh Das <asutoshd@xxxxxxxxxxxxxx>

  drivers/scsi/ufs/ufshcd.c | 5 +----
  drivers/scsi/ufs/ufshcd.h | 2 --
  2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 3d3289bb3cad..0c859f239d1c 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -6967,8 +6967,7 @@ static int ufshcd_add_lus(struct ufs_hba *hba)
  {
  	int ret;
- if (!hba->is_init_prefetch)
-		ufshcd_init_icc_levels(hba);
+	ufshcd_init_icc_levels(hba);
/* Add required well known logical units to scsi mid layer */
  	ret = ufshcd_scsi_add_wlus(hba);
@@ -6994,8 +6993,6 @@ static int ufshcd_add_lus(struct ufs_hba *hba)
  	scsi_scan_host(hba->host);
  	pm_runtime_put_sync(hba->dev);
- if (!hba->is_init_prefetch)
-		hba->is_init_prefetch = true;
  out:
  	return ret;
  }
diff --git a/drivers/scsi/ufs/ufshcd.h b/drivers/scsi/ufs/ufshcd.h
index 32b6714f25a5..5c65d9fdeb14 100644
--- a/drivers/scsi/ufs/ufshcd.h
+++ b/drivers/scsi/ufs/ufshcd.h
@@ -501,7 +501,6 @@ struct ufs_stats {
   * @intr_mask: Interrupt Mask Bits
   * @ee_ctrl_mask: Exception event control mask
   * @is_powered: flag to check if HBA is powered
- * @is_init_prefetch: flag to check if data was pre-fetched in initialization
   * @init_prefetch_data: data pre-fetched during initialization
   * @eh_work: Worker to handle UFS errors that require s/w attention
   * @eeh_work: Worker to handle exception events
@@ -652,7 +651,6 @@ struct ufs_hba {
  	u32 intr_mask;
  	u16 ee_ctrl_mask;
  	bool is_powered;
-	bool is_init_prefetch;
  	struct ufs_init_prefetch init_prefetch_data;
/* Work Queues */



--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux