On Mon, Jan 13, 2020 at 10:26 AM <Deepak.Ukey@xxxxxxxxxxxxx> wrote: > > Hi Jinpu, > > please use pm8001_ctl_num_phys_show as function name, so it follows > > same conversion as other functions. > > Better also rename controller_fatal_error too. > > If I tried to keep the function name as pm8001_ctl_num_phys_show as other function follows then checkpatch.pl gives the below warning. > > ------ > WARNING: Consider renaming function(s) 'pm8001_ctl_num_phys_show' to 'num_phys_show' > #37: FILE: drivers/scsi/pm8001/pm8001_ctl.c:108: > +} > > total: 0 errors, 1 warnings, 32 lines checked > ------- > > That’s the only reason I have changes the function name. For making the other function with same naming convention, I will change the function name of all other function like num_phys_show' and we will submit this patch in our upcoming patch set. > > Regards, > Deepak Thanks for checking, then we can do it later. PS: please avoid top-posting.
