Hi Martin, On Fri, 2020-01-10 at 01:25 -0500, Martin K. Petersen wrote: > Stanley, > > > Pass UFS device information to vendor-specific variant callback > > "apply_dev_quirks" because some platform vendors need to know such > > information to apply special handlings or quirks in specific devices. > > This doesn't compile. You missed adding the additional argument to one > caller of ufshcd_tune_unipro_params(). > Sorry for this. I'll fix it in next version and try to separate vendor's implementation and common driver to different commits if this is the root cause of compile issue. Thanks. Stanley