Hi Anand, First of all, you need a better commit descriptions with a rationale for each change. Several of the patches in the posted series have vague one-liners. In addition, this hunk seems odd: > + if (megasas_adp_reset_wait_for_ready > + (instance, true, 0) == FAILED) > + goto fail_ready_state; > + } else { > + goto fail_ready_state; > + } Couple of typos. And please add a space after /* and before */: > + /*waitting for about 30 second before retry*/ -- Martin K. Petersen Oracle Linux Engineering