On 1/8/2020 12:22 AM, Hannes Reinecke wrote:
boolean?
...
Same here?
...
See? It doesn't even hurt ...
:)
...
boolean?
yep - we'll convert them to boolean's
Ho-hum.
Maybe 'extend allocation not implemented' ?
ok
Didn't you mention extent allocation is not implemented?
So is this a different type of extent?
kinda - there was a comment header that tried to clarify this:
/* * Tracks the port resources using extents metaphor. For
* devices that don't implement extents (i.e.
* has_extents == FALSE), the code models each resource as
* a single large extent.
*/
regardless - we'll clarify what's going on.
+#define FDD 2
Oh, come on.
You have defines for everything but the kitchen sink.
So why do you have to define this one inline?
yeah - there are a lot.
Agree - the define will be moved to a header. It's a dump-type selection
(function scope or adapter scope; only newer things do function only).
Please use defines for the return values here.
One has no idea why '1' or '2' is returned here.
At the very least some documentation.
yep - will do.
EFC_SUCCESS is back!
I've already missed them; none of the previous functions in this patch
use them.
Please fix.
yep.
I guess you can reformat those; the linux line length is 80 characters,
and one really should use them ...
Cheers,
Hannes
We'll fix the line lengths.
-- james
