On Mon, 2006-12-11 at 18:18 +0100, Michael Schmitz wrote: > > Actually, isn't the correct fix to change SG_NONE to 1? > > > > We're deprecating the non-sg paths, however use_sg == 1 is equivalent to > > use_sg==0, you just set it up differently. > > I don't know how it's handled in the current code. The Atari driver > carries a big fat warning from the original author that the Falcon (my > test box) cannot do scatter-gather at all, due to problems with DMA setup. > > If sg_tablesize==1 is equivalent to not using scatter-gather, I can try > settin 1 there (but why isn't SG_NONE defined as 1, then?) Originally all drivers had a SG vs non-SG path through the queuecommand function. However, we're eliminating the non-SG path currently. However, if you only ever have one SG segment, that's functionally equivalent to the non-SG path (however, the setup would be different) so I think it's correct for SG_NONE to become 1 when this happens. James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
