You have to squash patch 1 & 2, otherwise your patch 1 won't compile. Other than that: looks good to me. Thanks, Avri ________________________________________ From: Stanley Chu <stanley.chu@xxxxxxxxxxxx> Sent: Sunday, January 5, 2020 6:55:15 AM To: linux-scsi@xxxxxxxxxxxxxxx; martin.petersen@xxxxxxxxxx; Avri Altman; alim.akhtar@xxxxxxxxxxx; jejb@xxxxxxxxxxxxx Cc: beanhuo@xxxxxxxxxx; asutoshd@xxxxxxxxxxxxxx; cang@xxxxxxxxxxxxxx; matthias.bgg@xxxxxxxxx; bvanassche@xxxxxxx; linux-mediatek@xxxxxxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; kuohong.wang@xxxxxxxxxxxx; peter.wang@xxxxxxxxxxxx; chun-hung.wu@xxxxxxxxxxxx; andy.teng@xxxxxxxxxxxx; Stanley Chu Subject: [PATCH v1 0/3] scsi: ufs: pass device information to apply_dev_quirks CAUTION: This email originated from outside of Western Digital. Do not click on links or open attachments unless you recognize the sender and know that the content is safe. Currently UFS driver has "global" device quirk scheme to allow driver applying special handling for certain UFS devive models. However some special device handlings are required for specific UFS hosts only so it is better to make it happen in vendor's callbacks only to not "pollute" common driver and common device quirks. We already have apply_dev_quirks variant callback for vendors but lack of device information for handling specific UFS device models. This series provides such information to apply_dev_quirks callbacks, and applies related modifications. Stanley Chu (3): scsi: ufs: pass device information to apply_dev_quirks scsi: ufs-qcom: modify apply_dev_quirks interface scsi: ufs-mediatek: add apply_dev_quirks variant operation drivers/scsi/ufs/ufs-mediatek.c | 11 +++++++++++ drivers/scsi/ufs/ufs-qcom.c | 3 ++- drivers/scsi/ufs/ufshcd.c | 5 +++-- drivers/scsi/ufs/ufshcd.h | 7 ++++--- 4 files changed, 20 insertions(+), 6 deletions(-) -- 2.18.0