On Fri, 08 Dec 2006 20:51:37 -0600 Linda Xie wrote: > Hi James, > > This patch changes the size of the buffer used for transfering config > data to 4K. It was tested against > 2.6.19-rc2 tree. > > Please consider it for inclusion in upstream. +/* host data buffer size */ +#define buff_size 4096 from Documentation/CodingStyle: <quote> Names of macros defining constants and labels in enums are capitalized. #define CONSTANT 0x12345 Enums are preferred when defining several related constants. CAPITALIZED macro names are appreciated but macros resembling functions may be named in lower case. </quote> I conclude that it should be BUFF_SIZE. --- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html