Hi On Mon, Dec 16, 2019 at 9:19 AM Stanley Chu <stanley.chu@xxxxxxxxxxxx> wrote: > > Add a header for the SiP service interface in order to access > the UFSHCI controller for secure command handling in MediaTek Chipsets. > > Signed-off-by: Stanley Chu <stanley.chu@xxxxxxxxxxxx> > --- > include/linux/soc/mediatek/mtk_sip_svc.h | 29 ++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h > > diff --git a/include/linux/soc/mediatek/mtk_sip_svc.h b/include/linux/soc/mediatek/mtk_sip_svc.h > new file mode 100644 > index 000000000000..97311959d7d7 > --- /dev/null > +++ b/include/linux/soc/mediatek/mtk_sip_svc.h > @@ -0,0 +1,29 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (C) 2019 MediaTek Inc. > + */ > +#ifndef __MTK_SIP_SVC_H > +#define __MTK_SIP_SVC_H > + > +/* Error Code */ > +#define SIP_SVC_E_SUCCESS 0 > +#define SIP_SVC_E_NOT_SUPPORTED -1 > +#define SIP_SVC_E_INVALID_PARAMS -2 > +#define SIP_SVC_E_INVALID_RANGE -3 > +#define SIP_SVC_E_PERMISSION_DENIED -4 > + > +#ifdef CONFIG_ARM64 > +#define MTK_SIP_SMC_CONVENTION ARM_SMCCC_SMC_64 > +#else > +#define MTK_SIP_SMC_CONVENTION ARM_SMCCC_SMC_32 > +#endif > + > +#define MTK_SIP_SMC_CMD(fn_id) \ > + ARM_SMCCC_CALL_VAL(ARM_SMCCC_FAST_CALL, MTK_SIP_SMC_CONVENTION, \ > + ARM_SMCCC_OWNER_SIP, fn_id) > + > +/* UFS related SMC call */ > +#define MTK_SIP_UFS_CONTROL \ > + MTK_SIP_SMC_CMD(0x276) > + How about moving UFS specific stuff to MTK UFS driver and include this header in driver file? Rest looks fine. > +#endif > -- > 2.18.0 -- Regards, Alim
