Re: [PATCH] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Michal Suchanek <msuchanek@xxxxxxx>
Subject: Re: [PATCH] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Tue, 17 Dec 2019 17:28:28 -0500
Cc: linux-scsi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>
In-reply-to: <20191217180840.9414-1-msuchanek@suse.de> (Michal Suchanek's message of "Tue, 17 Dec 2019 19:08:40 +0100")
Organization: Oracle Corporation
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux)

Michal,

> +	{"VMware", "VMware", NULL, BLIST_NO_MATCH_VENDOR | BLIST_NO_TRAY},

Please don't introduce a blist flag to work around deficiencies in the
matching interface. I suggest you tweak the matching functions so they
handle a NULL vendor string correctly.

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation
  - From: Michal Suchánek

References:
- [PATCH] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation
  - From: Michal Suchanek

Prev by Date: [PATCH v2 04/27] compat_ioctl: block: handle add zone open, close and finish ioctl
Next by Date: Re: [PATCH v1 2/2] scsi: ufs: disable interrupt during clock-gating
Previous by thread: [PATCH] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation
Next by thread: Re: [PATCH] scsi: blacklist: add VMware ESXi cdrom - broken tray emulation
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]