On Mon, Dec 16, 2019 at 02:45:35PM +0300, Roman Bolshakov wrote: > On Sat, Dec 14, 2019 at 04:09:41PM -0800, Bart Van Assche wrote: > > On 2019-12-13 17:04, Roman Bolshakov wrote: > > > Bart, what kernel do you use on initiator? Should we bring in > > > workarounds for initiators into mainline? > > > > The setup I use to test point-to-point mode is as follows: > > * A single server equipped with a QLE2562 adapter. > > * The two ports of the QLE2562 adapter directly connected to each other. > > * Both FC ports are assigned to a VM such that if a kernel crash occurs > > only the VM has to be rebooted (PCIe-passthrough). > > * The following in /etc/modprobe.d/qla2xxx.conf of the VM used for > > testing: > > > > options qla2xxx qlini_mode=dual ql2xextended_error_logging=0x5200b000 > > > > With this setup it is guaranteed that initiator and target are running > > the same kernel version. > > > > I run all my tests with mainline kernels. Typically I run my tests on > > top of a merge of Martin's scsi-fixes and scsi-queue branches. Since the > > regression that I reported is a regression in the upstream kernel I > > think the fix should go into the upstream kernel. > > > > Hi Bart, > > The setup details are helpful. Yes, I can reproduce it with > qlini_mode=dual. But it works with qlini_mode=disabled. > > But, qlini_mode=dual works if target is created before initiator is > started. So, the transition from initiator mode to target is the one > that needs a fix. > > There first PLOGI after target creation fails because it complains about > wrong D_ID in Login/Logout IOCB: > > qla2xxx [0000:00:07.0]-3873:1: Enter: PLOGI portid=0000ef > qla2xxx [0000:00:07.0]-3873:1: PLOGI 00000000003b33d0 00000000f1800318 > qla2xxx [0000:00:07.0]-3873:1: PLOGI buffer: > qla2xxx [0000:00:07.0]-0909:1: +116 0 1 2 3 4 5 6 7 8 9 A B C D E F > qla2xxx [0000:00:07.0]-0909:1: ----- ----------------------------------------------- > qla2xxx [0000:00:07.0]-0909:1: 0000: 03 00 00 00 20 20 00 0c 88 00 08 00 00 ff 00 1f > qla2xxx [0000:00:07.0]-0909:1: 0010: 00 00 07 d0 21 00 00 24 ff 7f 35 c7 20 00 00 24 > qla2xxx [0000:00:07.0]-0909:1: 0020: ff 7f 35 c7 00 00 00 00 00 00 00 00 00 00 00 00 > qla2xxx [0000:00:07.0]-0909:1: 0030: 00 00 00 00 00 00 00 00 20 00 08 00 00 ff 00 04 > qla2xxx [0000:00:07.0]-0909:1: 0040: 00 01 00 00 80 00 00 00 00 00 08 00 00 ff 00 00 > qla2xxx [0000:00:07.0]-0909:1: 0050: 00 01 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > qla2xxx [0000:00:07.0]-0909:1: 0060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > qla2xxx [0000:00:07.0]-0909:1: 0070: 00 00 00 00 > qla2xxx [0000:00:07.0]-3873:1: PLOGI ELS IOCB: > qla2xxx [0000:00:07.0]-0909:1: +64 0 1 2 3 4 5 6 7 8 9 A B C D E F > qla2xxx [0000:00:07.0]-0909:1: ----- ----------------------------------------------- > qla2xxx [0000:00:07.0]-0909:1: 0000: 53 01 00 00 05 00 00 00 00 00 00 00 01 00 00 10 > qla2xxx [0000:00:07.0]-0909:1: 0010: 00 00 00 00 01 00 03 00 ef 00 00 00 ef 00 00 00 > qla2xxx [0000:00:07.0]-0909:1: 0020: 74 00 00 00 74 00 00 00 00 00 a5 30 00 00 00 00 > qla2xxx [0000:00:07.0]-0909:1: 0030: 74 00 00 00 00 00 a6 30 00 00 00 00 74 00 00 00 > qla2xxx [0000:00:07.0]-3874:1: ELS_DCMD PLOGI sent, hdl=5, loopid=0, to port_id 0000ef from port_id 0000ef > qla2xxx [0000:00:07.0]-583f:1: ELS IOCB Done -Driver ELS logo error hdl=5 comp_status=0x31 error subcode 1=0x19 error subcode 2=0x18 total_byte=0x74 > qla2xxx [0000:00:07.0]-3872:1: ELS_DCMD ELS done rc 458752 hdl=5, portid=0000ef 21:00:00:24:ff:12:b1:a0 > qla2xxx [0000:00:07.0]-28eb:1: qla2x00_els_dcmd2_sp_done 21:00:00:24:ff:12:b1:a0 cmd error fw_status 0x31 0x19 0x18 > > Also note, that the IOCB is sent from port 0000ef to port 0000ef. This > is definitely wrong and should be fixed. I'm still looking how it > reached the invalid state. > Hi all again, Bart, In my setup I use QLE2560 as target (it has lower WWPN) and one port of QLE2742 as initiator. The proposed fix doesn't work for me. The same PLOGI error is returned. When target is started with qlini_mode=dual, the connection is initialized in AL_PA topology. FW assigns AL_PA for both ports. It sets AL_PA ef for the target port and e8 for initiator on my setup. LOOP DOWN event comes right after then target is created and existing rport is deleted by initiator without explicit LOGO and N_Port handle cleanup. Then the topology changes to N2N, the session is getting re-initialized, but initiator doesn't set correct D_ID for PLOGI, because FW returns wrong port id for initiator (ef instead of e8) in the response of Get ID mailbox command. Quinn, Himanshu, does it tell something to you? > If qla2xxx target is started with qlini_mode=disabled in P2P mode, > initiator/target have port ids 000001/000002. The port with bigger WWPN > in the pair typically assigns 000001 to itself and 000002 to the peer. > Thank you, Roman
