On 2019-12-15 17:34, cang@xxxxxxxxxxxxxx wrote: > This is applied to 5.5/scsi-queue. The two changes I patsed from you are > not merged yet, I am still doing code review to them, so there is no > blk_cleanup_queue() calls in my code base. I am just saying you may move > your blk_cleanup_queue() calls below cancel_work_sync(&hba->eh_work) if > my change applies. How do you think? > > scsi_host_put() was there before but explicitly removed by > afa3dfd42d205b106787476647735aa1de1a5d02. I agree with you, without this > change, there is memory leak. Hi Can, Since your patch restores a call that was removed earlier, please consider adding a Fixes: tag to your patch. Please also have a look at https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git/log/?h=5.6/scsi-queue. As one can see my patches that introduce blk_cleanup_queue() and blk_mq_free_tag_set() calls have already been queued on Martin's 5.6/scsi-queue branch. Bart.
