On Mon, Dec 09, 2019 at 10:02:23AM -0800, Bart Van Assche wrote:
> Instead of changing endianness in-place and copying the data in two steps,
> do this in one step. This patch makes is a preparation step for fixing the
> endianness warnings reported by 'sparse' for the qla2xxx driver.
>
> Cc: Quinn Tran <qutran@xxxxxxxxxxx>
> Cc: Martin Wilck <mwilck@xxxxxxxx>
> Cc: Daniel Wagner <dwagner@xxxxxxx>
> Cc: Roman Bolshakov <r.bolshakov@xxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
> drivers/scsi/qla2xxx/qla_def.h | 2 +-
> drivers/scsi/qla2xxx/qla_init.c | 9 ++++-----
> 2 files changed, 5 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_def.h b/drivers/scsi/qla2xxx/qla_def.h
> index ab7424318ee8..cf23f10d27fe 100644
> --- a/drivers/scsi/qla2xxx/qla_def.h
> +++ b/drivers/scsi/qla2xxx/qla_def.h
> @@ -414,7 +414,7 @@ struct els_logo_payload {
> struct els_plogi_payload {
> uint8_t opcode;
> uint8_t rsvd[3];
> - uint8_t data[112];
> + __be32 data[112 / 4];
> };
>
> struct ct_arg {
> diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
> index 6c28f38f8021..ddd8bf7997a8 100644
> --- a/drivers/scsi/qla2xxx/qla_init.c
> +++ b/drivers/scsi/qla2xxx/qla_init.c
> @@ -5047,13 +5047,12 @@ qla2x00_configure_local_loop(scsi_qla_host_t *vha)
> rval = qla24xx_get_port_login_templ(vha,
> ha->init_cb_dma, (void *)ha->init_cb, sz);
> if (rval == QLA_SUCCESS) {
> + __be32 *q = &ha->plogi_els_payld.data[0];
> +
> bp = (uint32_t *)ha->init_cb;
> - for (i = 0; i < sz/4 ; i++, bp++)
> - *bp = cpu_to_be32(*bp);
> + for (i = 0; i < sz/4 ; i++, bp++, q++)
> + *q = cpu_to_be32(*bp);
>
How about cpu_to_be32_array() instead of the hand-written loop?
> - memcpy(&ha->plogi_els_payld.data,
> - (void *)ha->init_cb,
> - sizeof(ha->plogi_els_payld.data));
> set_bit(RELOGIN_NEEDED, &vha->dpc_flags);
> } else {
> ql_dbg(ql_dbg_init, vha, 0x00d1,
Thanks,
Roman
