On Mon, Dec 09, 2019 at 10:02:21AM -0800, Bart Van Assche wrote: > Since the SCSI core does not reuse the tag of the SCSI command that is > being aborted by .eh_abort() before .eh_abort() has finished it is not > necessary to check from inside that callback whether or not the SCSI command > has already completed. Instead, rely on the firmware to return an error code > when attempting to abort a command that has already completed. Additionally, > rely on the firmware to return an error code when attempting to abort an > already aborted command. > > In qla2x00_abort_srb(), use blk_mq_request_started() instead of > sp->completed and sp->aborted. > > This patch eliminates several race conditions triggered by the removed member > variables. > Reviewed-by: Roman Bolshakov <r.bolshakov@xxxxxxxxx> Thanks, Roman
