Re: [PATCH 1/4] qla2xxx: Check locking assumptions at runtime in qla2x00_abort_srb()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 12/9/19, 12:02 PM, "linux-scsi-owner@xxxxxxxxxxxxxxx on behalf of Bart Van Assche" <linux-scsi-owner@xxxxxxxxxxxxxxx on behalf of bvanassche@xxxxxxx> wrote:

    Document the locking assumptions this function relies on and also verify these
    locking assumptions at runtime.
    
    Cc: Quinn Tran <qutran@xxxxxxxxxxx>
    Cc: Martin Wilck <mwilck@xxxxxxxx>
    Cc: Daniel Wagner <dwagner@xxxxxxx>
    Cc: Roman Bolshakov <r.bolshakov@xxxxxxxxx>
    Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
    ---
     drivers/scsi/qla2xxx/qla_os.c | 2 ++
     1 file changed, 2 insertions(+)
    
    diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
    index 8b84bc4a6ac8..145ea93206f0 100644
    --- a/drivers/scsi/qla2xxx/qla_os.c
    +++ b/drivers/scsi/qla2xxx/qla_os.c
    @@ -1700,6 +1700,8 @@ static void qla2x00_abort_srb(struct qla_qpair *qp, srb_t *sp, const int res,
     	bool ret_cmd;
     	uint32_t ratov_j;
     
    +	lockdep_assert_held(qp->qp_lock_ptr);
    +
     	if (qla2x00_chip_is_down(vha)) {
     		sp->done(sp, res);
     		return;
    
Looks Good. 

Acked-by: Himanshu Madhani <hmadhani@xxxxxxxxxxx>





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux