James Bottomley <James.Bottomley@xxxxxxxxxxxx> wrote:
> On Wed, 2006-12-06 at 00:14 +0100, Joerg Schilling wrote:
> > Well, accept the patch if it works.
>
> It's not about work/not work: it's about correctness.
>
> > And in case that you don't like it, make sure that the _parameter_ is
> > moved to where it belongs: to the low level transport layer.
>
> It's not a low level property; it's a property of the generic queue,
> namely the maximum request size. It exists for devices independent of
> SCSI (i.e. you'll want it for IDE and weirder transport attachment CDs
> as well).
It is a DMA property, so it is a low level property. The fact that the
parameter is held somewhere else does not change this.
BTW: I received a positive test result from a user, so the patch really
fixes the problems and we should use it.
Jörg
--
EMail:joerg@xxxxxxxxxxxxxxxxxxxxxxxxxxx (home) Jörg Schilling D-13353 Berlin
js@xxxxxxxxxxxxxxx (uni)
schilling@xxxxxxxxxxxxxxxxxxx (work) Blog: http://schily.blogspot.com/
URL: http://cdrecord.berlios.de/old/private/ ftp://ftp.berlios.de/pub/schily
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
