On 11/26/19 12:54 PM, Michal Suchanek wrote: > Hello, > > there is cdrom autoclose feature that is supposed to close the tray, > wait for the disc to become ready, and then open the device. > > This used to work in ancient times. Then in old times there was a hack > in util-linux which worked around the breakage which probably resulted > from switching to scsi emulation. > > Currently util-linux maintainer refuses to merge another hack on the > basis that kernel still has the feature so it should be fixed there. > The code needs not be replicated in every userspace utility like mount > or dd which has no business knowing which devices are CD-roms and where > the autoclose setting is in the kernel. > > This is rebase on top of current master. > > Also it seems that most people think that this is fix for WMware because > there is one patch dealing with WMware. I think the main complaint with this is that it's kind of a stretch to add core functionality for a device type that's barely being manufactured anymore and is mostly used in a virtualized fashion. I think it you could fix this without 10 patches of churn and without adding a new ->open() addition to fops, then people would be a lot more receptive to the idea of improving cdrom auto-close. -- Jens Axboe
