Alan Stern wrote:
I decided to do this by email instead of bugzilla so that it would be
visible to everyone on the linux-scsi mailing list.
Re: http://bugzilla.kernel.org/show_bug.cgi?id=7026
To recap: Joerg Schilling needs to be able to retrieve the max_sectors
value for a SCSI device's request queue. Doing it via sysfs is rather
clumsy, especially when only a file descriptor is available and not the
device name. He has asked for an ioctl interface to provide the
information.
Is the patch below acceptable?
Alan,
I just spent an hour thinking about how to data mine through
that dreadful mess that /sys has become as I try to add
transport information to lsscsi.
And then this post made my day. Fancy that, adding a new
ioctl!! I hope the ioctl police aren't watching :-)
Apart from sensibly yielding the max size in bytes, your patch
has the added benefit of allowing non-block devices (e.g. tape,
processor and enclosure services) to find out what limit the
OS/host has placed on each command's maximum transfer size.
If you manage to get that ioctl in, then ungrateful people
will ask for the corresponding "set" operation as well.
To illustrate the /sys mess look at naming of the sysfs approach
to this problem. For example:
/sys/block/sde/queue/max_sectors_kb
- it is not only a "block" property
- sde is an "end device" and suggests information from that
device's Block Limits VPD page, actually it is a limit
imposed by the OS and the host used to access that device
- what has "queue" got to do with it?
- "max_sectors_kb" should have units of bytes
And /sys has the horrible side effect of enshrining a badly
conceived design in a user interface (and SAS comes to mind).
Best of luck
Doug Gilbert
BTW Joerg: SG_SET_RESERVED_SIZE simply makes it extremely
unlikely that the sg driver will not be able to fetch
enough memory from the kernel to move data associated with
a SCSI command. The block layer SG_IO just fudges that.
While a major concern in lk 2.0, memory starvation is typically
not a major concern in lk 2.6 assuming modern hardware.
The sg driver's reserved buffer has other uses as
FUJITA Tomonori pointed out yesterday on the linux-scsi list.
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
