> > On 2019-11-20 23:36, Avri Altman wrote: > >> > >> If PM QoS is enabled and we set request type to PM_QOS_REQ_AFFINE_IRQ > >> then freeing up the irq makes the free_irq() print out warning with > >> call stack. > >> We don't really need to free up irq during suspend, disabling it > >> during suspend and reenabling it during resume should be good enough. > >> > >> Signed-off-by: Can Guo <cang@xxxxxxxxxxxxxx> > > Your approach seems reasonable, > > However I failed to locate in the kernel PM_QOS_REQ_AFFINE_IRQ, Just > > in codeaurora. > > > > Is the WARN_ON in free_irq still applies? > > > > Thanks, > > Avri > > Hi Avri, > > Thanks for pointing. It seems PM_QOS_REQ_AFFINE_IRQ is not present on > upstream yet. But this change is still applicable. > How about changing the commit message to below? > > "Since ufshcd irq resource is allocated with the device resource management > aware IRQ request implementation, we don't really need to free up irq during > suspend, disabling it during suspend and reenabling it during resume should be > good enough." Looks good to me. Thanks, Avri > > Thanks, > Can Guo
