On Fri, Nov 22, 2019 at 05:04:52AM +0000, Mark Harvey wrote:
> Would this not result in a memory leak in the 'else' path - skiping sp->free(sp)?
>
> - wait_for_completion(&elsio->u.els_logo.comp);
> + if (wait) {
> + wait_for_completion(&elsio->u.els_logo.comp);
> + } else {
> + goto done;
> + }
>
> sp->free(sp);
> +done:
> return rval;
> }
>
Hi Mark,
Good catch, it definetely will be a leak. I had this on mind but forgot
while rushing to post v2. I'll add proper cleanup in v3.
Thank you,
Roman
