On Tue, Dec 05 2006, Boaz Harrosh wrote: > While working on bidi support at struct request level > I have found that blk_queue_activity_fn is actually never used. > The only user is in ide-probe.c with this code: > > /* enable led activity for disk drives only */ > if (drive->media == ide_disk && hwif->led_act) > blk_queue_activity_fn(q, hwif->led_act, drive); > > And led_act is never initialized anywhere. > (Looking back at older kernels it was used in the PPC arch, but was removed around 2.6.18) > Unless it is all for future use off course. > (this patch is against linux-2.6-block.git as off 2006/12/4) I didn't notice it had been removed from pmac in 2.6.18, since that is the case we can kill it. Thanks, I've queued the patch for inclusion. -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html