Hi, On 19/11/19 12:34 PM, sheebab wrote: > Hi, > > Resending this patch to include mailing list and miss out patches. > > This patch set contains following patches > for Cadence UFS controller driver. > > 1. 0001-scsi-ufs-Enable-hibern8-interrupt-only-during-manual.patch > This patch is to fix false interrupt assertion during auto hibernation. > In this patch, hibern8 interrupt is Disabled during initialization > and later the interrupt is Enabled/Disabled during manual hibern8 > Entry/Exit. > 2. 0002-scsi-ufs-Update-L4-attributes-on-manual-hibern8-exit.patch > This patch is to update L4 attributes during manual hibern8 exit. > As per JESD220C spec, L4 attributes will be reset to their reset value > during DME_HIBERNATION_EXIT. This patch will take backup of the L4 > parameters before DME_HIBERNATION_ENTER and restores the L4 parameters > after DME_HIBERNATION_EXIT > While I don't see flood of hibernate related interrupts anymore, I occasionally see "Unhandled Interrupt dump"[1] when using rootfs out of UFS. I haven't be able to find a way to trigger the issue. But seems to happen randomly while trying to input and execute something from console. [1] j7-evm login: root [ 55.300495] cdns-ufshcd 4e84000.ufs: ufshcd_intr: Unhandled interrupt 0x00000000 [ 55.307884] host_regs: 00000000: 1587031f 00000000 00000210 00000000 [ 55.314217] host_regs: 00000010: 00000000 00000000 00000c96 00000000 [ 55.320551] host_regs: 00000020: 00000014 00030e15 00000000 00000000 [ 55.326884] host_regs: 00000030: 0000010f 00000001 00000000 80000002 [ 55.333217] host_regs: 00000040: 00000000 00000000 00000000 00000000 [ 55.339551] host_regs: 00000050: c1ee0000 00000008 00008000 00000000 [ 55.345884] host_regs: 00000060: 00000001 ffffffff 00000000 00000000 [ 55.352217] host_regs: 00000070: c1ef0000 00000008 00000000 00000000 [ 55.358550] host_regs: 00000080: 00000001 00000000 00000000 00000000 [ 55.364884] host_regs: 00000090: 00000002 15710000 00000000 00000000 More such occurrence: https://pastebin.ubuntu.com/p/Df4dykkTmB/ > > Thanks, > Sheeba B > > sheebab (2): > scsi: ufs: Enable hibern8 interrupt only during manual hibern8 in > Cadence UFS. > scsi: ufs: Update L4 attributes on manual hibern8 exit in Cadence UFS. > > drivers/scsi/ufs/cdns-pltfrm.c | 172 +++++++++++++++++++++++++++++++++-- > 1 file changed, 167 insertions(+), 5 deletions(-) > -- Regards Vignesh