akpm@xxxxxxxx wrote:
> From: Akinobu Mita <akinobu.mita@xxxxxxxxx>
>
> The return value of crypto_alloc_hash() should be checked by
> IS_ERR().
Looks good to me.
Signed-off-by: Mike Christie <michaelc@xxxxxxxxxxx>
Either James can merge it or Andrew can forward it or if when I send my
update it is not merged by someone I will resend it.
>
> Cc: Dmitry Yusupov <dmitry_yus@xxxxxxxxx>
> Cc: Alex Aizman <itn780@xxxxxxxxx>
> Signed-off-by: Akinobu Mita <akinobu.mita@xxxxxxxxx>
> Cc: James Bottomley <James.Bottomley@xxxxxxxxxxxx>
> Signed-off-by: Andrew Morton <akpm@xxxxxxxx>
> ---
>
> drivers/scsi/iscsi_tcp.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff -puN drivers/scsi/iscsi_tcp.c~iscsi-fix-crypto_alloc_hash-error-check drivers/scsi/iscsi_tcp.c
> --- a/drivers/scsi/iscsi_tcp.c~iscsi-fix-crypto_alloc_hash-error-check
> +++ a/drivers/scsi/iscsi_tcp.c
> @@ -1777,13 +1777,13 @@ iscsi_tcp_conn_create(struct iscsi_cls_s
> tcp_conn->tx_hash.tfm = crypto_alloc_hash("crc32c", 0,
> CRYPTO_ALG_ASYNC);
> tcp_conn->tx_hash.flags = 0;
> - if (!tcp_conn->tx_hash.tfm)
> + if (IS_ERR(tcp_conn->tx_hash.tfm))
> goto free_tcp_conn;
>
> tcp_conn->rx_hash.tfm = crypto_alloc_hash("crc32c", 0,
> CRYPTO_ALG_ASYNC);
> tcp_conn->rx_hash.flags = 0;
> - if (!tcp_conn->rx_hash.tfm)
> + if (IS_ERR(tcp_conn->rx_hash.tfm))
> goto free_tx_tfm;
>
> return cls_conn;
> _
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
