On Mon, 2019-11-04 at 10:01 +0100, Hannes Reinecke wrote: > The driver_byte field in the result is now unused, so we can drop > the definitions. > > Signed-off-by: Hannes Reinecke <hare@xxxxxxx> > --- > Documentation/scsi/scsi_mid_low_api.txt | 3 +-- > block/bsg-lib.c | 2 +- > block/bsg.c | 2 +- > block/scsi_ioctl.c | 2 +- > drivers/scsi/constants.c | 14 -------------- > drivers/scsi/scsi_logging.c | 10 ++-------- > drivers/scsi/sd.c | 9 ++++----- > drivers/scsi/sd_zbc.c | 4 ++-- > drivers/scsi/sg.c | 5 ++--- > drivers/scsi/sr.c | 2 +- > drivers/scsi/sr_ioctl.c | 2 +- > drivers/scsi/st.c | 4 ++-- > include/scsi/scsi.h | 3 --- > include/scsi/scsi_cmnd.h | 4 ---- > include/trace/events/scsi.h | 7 +------ > 15 files changed, 19 insertions(+), 54 deletions(-) > While I generally like this change, the driver byte is part of the sg_io user space API, and used in sg3_utils and multipath-tools (in particular, DRIVER_SENSE), and likely in other user space tools as well. Can we simply ditch it without adding some compatibility code to sg and bsg? Thanks, Martin
