On Fri, Nov 15, 2019 at 01:27:56PM +0100, Hannes Reinecke wrote: > Use scsi_host_busy_iter() for traversing outstanding commands and > drop the cmd_list usage. This is missing all the feedback from last time, no maintainers are Cced, it is not split up and properly documented, etc. It is still reverse engineering the scsi commands instead of looking at the block request. And while looking at this again, I think the iteration in aac_synchronize should simply be removed without a replacement. Cache flushes in the Linux block layer and in SCSI have always only been for complete commands, not for in-flight commands. So unless the hardware has a weird quirk this code should just go away. Which is another reason to add the maintainers at the hardware vendor, as they can help with insights.
