Re: [PATCH] scsi_debug: num_tgts must be >= 0

[Douglas Gilbert <dgilbert@xxxxxxxxxxxx>]

On 2019-11-16 3:37 a.m., Maurizio Lombardi wrote:
> Passing the parameter "num_tgts=-1" will start
> an infinite loop that exhausts the system memory

Ouch.

> Signed-off-by: Maurizio Lombardi <mlombard@xxxxxxxxxx>

Acked-by: Douglas Gilbert <dgilbert@xxxxxxxxxxxx>

> ---
>   drivers/scsi/scsi_debug.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c
> index d323523f5f9d..32965ec76965 100644
> --- a/drivers/scsi/scsi_debug.c
> +++ b/drivers/scsi/scsi_debug.c
> @@ -5263,6 +5263,11 @@ static int __init scsi_debug_init(void)
>   		return -EINVAL;
>   	}
>   
> +	if (sdebug_num_tgts < 0) {
> +		pr_err("num_tgts must be >= 0\n");
> +		return -EINVAL;
> +	}
> +
>   	if (sdebug_guard > 1) {
>   		pr_err("guard must be 0 or 1\n");
>   		return -EINVAL;