On 2019-11-14 09:03, cang@xxxxxxxxxxxxxx wrote:
On 2019-11-14 06:04, Bean Huo (beanhuo) wrote:
In UFS host reset and restore path, before probe, we stop and start
the host
controller once. After host controller is stopped, the pending
requests, if any,
are cleared from the doorbell, but no completion IRQ would be raised
due to the
hba is stopped.
These pending requests shall be completed along with the first
NOP_OUT
command(as it is the first command which can raise a transfer
completion
IRQ) sent during probe.
Hi, Can
I am not sure for this point, because there is HW/SW device reset
before or after host reset/restore.
Device HW/SW reset also will clear the pended tasks in device side.
That will be better.
I think Qcom platform already enabled HW reset.
//Bean
Hi Bean,
By pending tasks here, it means the requests sent down from scsi/block
layer,
but have not yet been handled by ufs driver(cmd->scsi_done() have not
been called yet for these requests).
For these requests, although removed by host and UFS device in their
HW queues(doorbell),
UFS driver still needs to complete them from SW side(call
cmd->scsi_done() for each one of them) to
let upper layer know that they are finished(although not successfully)
to avoid hitting
timeout of these pending tasks. I hope I make my explanation clearly.
Best Regards,
Can Guo.
Hi Bean,
Just want to add up more phrases. We do have HW/SW reset.
Sorry about below lines which make you confused. Here I am just
describing what
is like with previous code. Since these pending requests does not have
a chance to be handled in their IRQ handler after hba is stopped, and as
they have been cleared from doorbell already, then once there is an
available
transfer completion IRQ, these requests will be handled in the IRQ
handler,
no matter what is the transfer completion IRQ fired for. And NOP_OUT is
just
the first command that can fire a transer completion IRQ.
Can Guo.
These pending requests shall be completed along with the first NOP_OUT
command(as it is the first command which can raise a transfer completion
IRQ) sent during probe.
Since the OCSs of these pending requests are not SUCCESS(because they
are not
yet literally finished), their UPIUs shall be dumped. When there are
multiple
pending requests, the UPIU dump can be overwhelming and may lead to
stability
issues because it is in atomic context.
Therefore, before probe, complete these pending requests right after
host
controller is stopped.
