Hi Christoph! Op wo 13 nov. 2019 om 15:22 schreef Christoph Hellwig <hch@xxxxxxxxxxxxx>: > > On Tue, Nov 12, 2019 at 07:57:09PM +0100, Kars de Jong wrote: > > The order of the definitions in the esp_rev enum is important. The values > > are used in comparisons for chip features. > > Yikes. Wouldn't it make much more sense to have a feature bitmap? Yes, I mentioned that in my cover letter already, and it was discussed a bit on the Linux/m68k mailing list. It may be hard to get that tested though, most of the users are legacy architectures with a probably very limited number of users. But if a mostly review-based process is good enough, I am certainly willing to change it. Kind regards, Kars.
