Re: [PATCH -next] scsi: ufshcd: Remove dev_err() on platform_get_irq() failure

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: YueHaibing <yuehaibing@xxxxxxxxxx>
Subject: Re: [PATCH -next] scsi: ufshcd: Remove dev_err() on platform_get_irq() failure
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Tue, 12 Nov 2019 21:31:10 -0500
Cc: <alim.akhtar@xxxxxxxxxxx>, <avri.altman@xxxxxxx>, <pedrom.sousa@xxxxxxxxxxxx>, <jejb@xxxxxxxxxxxxx>, <martin.petersen@xxxxxxxxxx>, <stanley.chu@xxxxxxxxxxxx>, <arnd@xxxxxxxx>, <linux-scsi@xxxxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20191101140058.23212-1-yuehaibing@huawei.com> (yuehaibing@huawei.com's message of "Fri, 1 Nov 2019 22:00:58 +0800")
Organization: Oracle Corporation
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux)

YueHaibing,

> platform_get_irq() will call dev_err() itself on failure, so there is
> no need for the driver to also do this.  This is detected by
> coccinelle.

Applied to 5.5/scsi-queue, thanks.

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH -next] scsi: ufshcd: Remove dev_err() on platform_get_irq() failure
  - From: YueHaibing

Prev by Date: Re: [PATCH -next] scsi: csiostor: Remove set but not used variable 'rln'
Next by Date: Re: [PATCH v2 0/9] Zoned block device enhancements and zone report rework
Previous by thread: [PATCH -next] scsi: ufshcd: Remove dev_err() on platform_get_irq() failure
Next by thread: [PATCH] drivers/scsi/esas2r: Replace binary semaphore with mutex
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux