On Thu, Nov 7, 2019 at 7:20 AM <Deepak.Ukey@xxxxxxxxxxxxx> wrote: > > On Thu, Oct 31, 2019 at 6:12 AM Deepak Ukey <deepak.ukey@xxxxxxxxxxxxx> wrote: > > > > From: Deepak Ukey <Deepak.Ukey@xxxxxxxxxxxxx> > > > > Added support to check controller fatal error through sysfs. > > > > Signed-off-by: Deepak Ukey <deepak.ukey@xxxxxxxxxxxxx> > > Signed-off-by: Viswas G <Viswas.G@xxxxxxxxxxxxx> > > --- > > drivers/scsi/pm8001/pm8001_ctl.c | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/drivers/scsi/pm8001/pm8001_ctl.c > > b/drivers/scsi/pm8001/pm8001_ctl.c > > index 6b85016b4db3..fbdd0bf0e1ab 100644 > > --- a/drivers/scsi/pm8001/pm8001_ctl.c > > +++ b/drivers/scsi/pm8001/pm8001_ctl.c > > @@ -69,6 +69,25 @@ static ssize_t > > pm8001_ctl_mpi_interface_rev_show(struct device *cdev, static > > DEVICE_ATTR(interface_rev, S_IRUGO, pm8001_ctl_mpi_interface_rev_show, > > NULL); > > > > +/** > > + * pm8001_ctl_controller_fatal_err - check controller is under fatal > > +err > > + * @cdev: pointer to embedded class device > > + * @buf: the buffer returned > > + * > > + * A sysfs 'read only' shost attribute. > > + */ > > +static ssize_t controller_fatal_error_show(struct device *cdev, > > + struct device_attribute *attr, char *buf) > The kernel-doc doesn't match the function name, please fix it. > --Can you please tell me which function name you are pointing out. Is it about the difference in function description in the > comment (pm8001_ctl_controller_fatal_err) and actual function name (controller_fatal_error_show) ? Yes.
