Hi Bart / Avri On Tue, Nov 5, 2019 at 9:47 PM Alim Akhtar <alim.akhtar@xxxxxxxxx> wrote: > > Hi > > On Mon, Nov 4, 2019 at 6:29 PM Avri Altman <Avri.Altman@xxxxxxx> wrote: > > > > As no response from Kiwoong Kim: > > > > > > > > > > > + Kiwoong Kim > Looks like he is not active here. > > > > > > > > > > > Since the function ufshcd_vops_setup_xfer_req() is the only user of > > > > the setup_xfer_req function pointer and since that function pointer is > > > > always zero, remove both this function and the function pointer. This > > > > patch does not change any functionality. > > > > > > > > Cc: Yaniv Gardi <ygardi@xxxxxxxxxxxxxx> > > > > Cc: Subhash Jadavani <subhashj@xxxxxxxxxxxxxx> > > > > Cc: Stanley Chu <stanley.chu@xxxxxxxxxxxx> > > > > Cc: Avri Altman <avri.altman@xxxxxxx> > > > > Cc: Tomas Winkler <tomas.winkler@xxxxxxxxx> > > > > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > > > Since this was introduced only a couple of years ago, Maybe better to CC the > > > author Kiwoong Kim <kwmad.kim@xxxxxxxxxxx> Before removing this > > > altogether. > > Reviewed-by: Avri Altman <avri.altman@xxxxxxx> > > Let me check and reconfirm this, give a day or two. > It will be good if am copied to the ufs patch (I hope > get_maintainer.pl still pointout my email) > thanks > I checked the brief history of this adding "setup_xfer_req" to support Samsung UFSHCI (this was the ground work done) We need this to support vendor specific NEXUS_TYPE settings. The Samsung UFSHCI driver will be up for review in near future For usecase of the function pointer please see an older version of the patch https://patchwork.kernel.org/patch/7306321/ > -- > Regards, > Alim -- Regards, Alim
