On Mon, Nov 4, 2019 at 1:04 AM Hannes Reinecke <hare@xxxxxxx> wrote:
>
> twa_fill_sense() can never return '1', so the check is pointless.
>
> Signed-off-by: Hannes Reinecke <hare@xxxxxxx>
> ---
> drivers/scsi/3w-9xxx.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/scsi/3w-9xxx.c b/drivers/scsi/3w-9xxx.c
> index 3337b1e80412..b275ce3b0fbd 100644
> --- a/drivers/scsi/3w-9xxx.c
> +++ b/drivers/scsi/3w-9xxx.c
> @@ -1339,12 +1339,6 @@ static irqreturn_t twa_interrupt(int irq, void *dev_instance)
> cmd->result = (DID_OK << 16);
> }
>
> - /* If error, command failed */
> - if (error == 1) {
> - /* Ask for a host reset */
> - cmd->result = (DID_OK << 16) | (CHECK_CONDITION << 1);
> - }
> -
> /* Report residual bytes for single sgl */
> if ((scsi_sg_count(cmd) <= 1) && (full_command_packet->command.newcommand.status == 0)) {
> if (full_command_packet->command.newcommand.sg_list[0].length < scsi_bufflen(tw_dev->srb[request_id]))
> --
> 2.16.4
>
Acked-by: Adam Radford <aradford@xxxxxxxxx>
