On 11/1/19 9:54 AM, Hannes Reinecke wrote:
On 11/1/19 5:26 PM, Bart Van Assche wrote:
On 10/31/19 4:04 AM, Hannes Reinecke wrote:
Use standard SAM status codes and omit the explicit shift to convert
to linux-specific ones.
Isn't an explicit shift required to convert *from* linux-specific
codes instead of for converting *to* linux-specific ones?
drivers/ata/libata-scsi.c | 2 +-
drivers/infiniband/ulp/srp/ib_srp.c | 2 +-
drivers/scsi/3w-9xxx.c | 5 +++--
drivers/scsi/3w-sas.c | 3 ++-
drivers/scsi/3w-xxxx.c | 4 ++--
drivers/scsi/arcmsr/arcmsr_hba.c | 4 ++--
drivers/scsi/bfa/bfad_im.c | 2 +-
drivers/scsi/dc395x.c | 18 +++++-------------
drivers/scsi/dpt_i2o.c | 2 +-
drivers/scsi/gdth.c | 12 ++++++------
drivers/scsi/megaraid.c | 10 +++++-----
drivers/scsi/megaraid/megaraid_mbox.c | 12 ++++++------
drivers/scsi/pcmcia/nsp_cs.c | 2 +-
13 files changed, 36 insertions(+), 42 deletions(-)
Should this patch be split into one patch per driver such? If this
patch would introduce a regression that will make it easier to address
such regressions. Splitting this patch will also make reviewing easier.
If you think it's worthwhile ... sure.
I'm already at 24 patches; splitting this off would get me an additional
12 patches, all of which are basically one-liners.
Usually SCSI LLD authors only add their Reviewed-by tags to patches that
only touch their driver and no other SCSI LLDs.
How about splitting this patch series into multiple smaller series?
Thanks,
Bart.
