> >>> "wubo (T)" <wubo40@xxxxxxxxxx> schrieb am 30.10.2019 um 08:56 in
> Nachricht
> <EDBAAA0BBBA2AC4E9C8B6B81DEEE1D6915DFA0FE@dggeml505-mbs.china.
> huawei.com>:
> > From: Bo Wu <wubo40@xxxxxxxxxx>
>
> ...
> > + if (--retries < 0) {
> > + printk(KERN_ERR "Send reply failed too many times. "
> > + "Max supported retries %u\n",
> ISCSI_SEND_MAX_ALLOWED);
>
> Just for "personal taste": Why not simplify the message to:?
> + printk(KERN_ERR "Send reply failed too many times
> (%u)\n",
> ISCSI_SEND_MAX_ALLOWED);
>
> > + break;
> > + }
> > +
>
> Maybe place the number after "many" as an alternative. I think as the
> message is expected to be rare, a short variant is justified.
Thanks for your suggestion. This problem occured when iscsi_if_send_reply returns -EAGAIN.
Consider possible other anomalies scenes. In order to get diagnostic information, it is better to replace "many" with error code.
Modify as follow:
if (--retries < 0) {
printk(KERN_WARNING "Send reply failed, error %d\n", err);
break;
}
> Also one could discuss wether the problem that originates "from external"
> should be KERN_ERR, or maybe just a warning, because the kernel itself can do
> little against that problem, and it's not a "kernel error" after all ;-)
You are right, This problem scene rarely appears .it is friendly to replace the error with warning.
>
> Regards,
> Ulrich
>
>
>
Thanks,
Bo Wu
