Re: [PATCH 24/32] elx: efct: LIO backend interface routines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/28/19 10:49 AM, James Smart wrote:
On 10/24/2019 3:27 PM, Bart Van Assche wrote:
+static const struct file_operations efct_debugfs_session_fops = {
+    .owner        = THIS_MODULE,
+    .open        = efct_debugfs_session_open,
+    .release    = efct_debugfs_session_close,
+    .read        = efct_debugfs_session_read,
+    .write        = efct_debugfs_session_write,
+    .llseek        = default_llseek,
+};
+
+static const struct file_operations efct_npiv_debugfs_session_fops = {
+    .owner        = THIS_MODULE,
+    .open        = efct_npiv_debugfs_session_open,
+    .release    = efct_debugfs_session_close,
+    .read        = efct_debugfs_session_read,
+    .write        = efct_debugfs_session_write,
+    .llseek        = default_llseek,
+};

Since the information that is exported through debugfs (logged in initiators) is information that is also useful for other target drivers, I think this functionality should be implemented in the target core instead of in this target driver.

Can you expand further on what you'd like to see and the format of the data to be displayed ?

(+Mike)

Mike, can you comment on the status of your patch "target: add session dir in configfs" (https://patchwork.kernel.org/patch/10525321/)?

Thanks,

Bart.



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux