The reason code for REQ_OP_RESET_ALL is kept in a different function so we can clearly differentiate between REQ_OP_RESET and REQ_OP_RESET_ALL when we add new tracepoints with blktrace framework. But if that is acceptable, then, Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@xxxxxxx> On 10/27/19 7:06 AM, Damien Le Moal wrote: > There is no need for the function __blkdev_reset_all_zones() as > REQ_OP_ZONE_RESET_ALL can be handled directly in blkdev_reset_zones() > bio loop with an early break from the loop. This patch removes this > function and modifies blkdev_reset_zones(), simplifying the code. > > Signed-off-by: Damien Le Moal<damien.lemoal@xxxxxxx>