Hi James, > Review comments welcome! My compiler is complaining: home/wagi/work/linux/drivers/scsi/elx/efct/efct_driver.c: In function ‘efct_request_firmware_update’: /home/wagi/work/linux/drivers/scsi/elx/efct/efct_driver.c:350:3: warning: ‘fw_change_status’ may be used uninitialized in this function [-Wmaybe-uninitialized] 350 | switch (fw_change_status) { | ^~~~~~ CC drivers/scsi/elx/libefc/efc_device.o CC drivers/scsi/elx/libefc/efc_lib.o CC drivers/scsi/elx/libefc/efc_sm.o CC drivers/scsi/elx/libefc_sli/sli4.o /home/wagi/work/linux/drivers/scsi/elx/libefc_sli/sli4.c: In function ‘sli_fc_rq_set_alloc’: /home/wagi/work/linux/drivers/scsi/elx/libefc_sli/sli4.c:818:12: warning: ‘offset’ may be used uninitialized in this function [-Wmaybe-uninitialized] 818 | u32 i, p, offset; | ^~~~~~ Thanks, Daniel