Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Michal Suchánek <msuchanek@xxxxxxx>
Subject: Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 24 Oct 2019 19:39:08 -0700
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, Jonathan Corbet <corbet@xxxxxxx>, Jens Axboe <axboe@xxxxxxxxx>, "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Alexander Viro <viro@xxxxxxxxxxxxxxxxxx>, Mauro Carvalho Chehab <mchehab+samsung@xxxxxxxxxx>, Eric Biggers <ebiggers@xxxxxxxxxx>, "J. Bruce Fields" <bfields@xxxxxxxxxx>, Benjamin Coddington <bcodding@xxxxxxxxxx>, Hannes Reinecke <hare@xxxxxxxx>, Omar Sandoval <osandov@xxxxxx>, Ming Lei <ming.lei@xxxxxxxxxx>, Damien Le Moal <damien.lemoal@xxxxxxx>, Bart Van Assche <bvanassche@xxxxxxx>, Tejun Heo <tj@xxxxxxxxxx>, linux-doc@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx
In-reply-to: <20191024085014.GF938@kitsune.suse.cz>
User-agent: Mutt/1.12.1 (2019-06-15)

On Thu, Oct 24, 2019 at 10:50:14AM +0200, Michal Suchánek wrote:
> Then I will get complaints I do unrelated changes and it's hard to
> review. The code gets removed later anyway.

If you refactor you you pretty much have a card blanche for the
refactored code and the direct surroundings.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code
  - From: Michal Suchánek

References:
- [PATCH v2 0/8] Fix cdrom autoclose.
  - From: Michal Suchanek
- [PATCH v2 2/8] cdrom: factor out common open_for_* code
  - From: Michal Suchanek
- Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code
  - From: Christoph Hellwig
- Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code
  - From: Michal Suchánek

Prev by Date: Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code
Next by Date: Re: [PATCH 1/4] block: Enhance blk_revalidate_disk_zones()
Previous by thread: Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code
Next by thread: Re: [PATCH v2 2/8] cdrom: factor out common open_for_* code
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]