On Wed, Oct 23, 2019 at 07:19:58PM -0700, Christoph Hellwig wrote: > > static > > -int open_for_data(struct cdrom_device_info *cdi) > > +int open_for_common(struct cdrom_device_info *cdi, tracktype *tracks) > > Please fix the coding style. static never should be on a line of its > own.. It's OK to have the static on a line by itself; it's having 'static int' on a line by itself that Linus gets unhappy about because he can't use grep to see the return type. But there's no need for it to be on a line by itself here, it all fits fine in 80 columns.
