Re: [PATCH 09/24] scsi: Kill obsolete linux-specific status codes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hannes,

I love your patch! Yet something to improve:

[auto build test ERROR on mkp-scsi/for-next]
[cannot apply to v5.4-rc4 next-20191021]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Hannes-Reinecke/scsi-Revamp-result-values/20191022-004918
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=sh 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>):

   drivers/scsi/pcmcia/nsp_cs.c: In function 'nsp_queuecommand_lck':
>> drivers/scsi/pcmcia/nsp_cs.c:226:22: error: 'CHECK_CONDITION' undeclared (first use in this function); did you mean 'SEC_CONVERSION'?
     SCpnt->SCp.Status = CHECK_CONDITION;
                         ^~~~~~~~~~~~~~~
                         SEC_CONVERSION
   drivers/scsi/pcmcia/nsp_cs.c:226:22: note: each undeclared identifier is reported only once for each function it appears in

vim +226 drivers/scsi/pcmcia/nsp_cs.c

^1da177e4c3f41 Linus Torvalds 2005-04-16  221  
^1da177e4c3f41 Linus Torvalds 2005-04-16  222  	show_command(SCpnt);
^1da177e4c3f41 Linus Torvalds 2005-04-16  223  
^1da177e4c3f41 Linus Torvalds 2005-04-16  224  	data->CurrentSC		= SCpnt;
^1da177e4c3f41 Linus Torvalds 2005-04-16  225  
^1da177e4c3f41 Linus Torvalds 2005-04-16 @226  	SCpnt->SCp.Status	= CHECK_CONDITION;
^1da177e4c3f41 Linus Torvalds 2005-04-16  227  	SCpnt->SCp.Message	= 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  228  	SCpnt->SCp.have_data_in = IO_UNKNOWN;
^1da177e4c3f41 Linus Torvalds 2005-04-16  229  	SCpnt->SCp.sent_command = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  230  	SCpnt->SCp.phase	= PH_UNDETERMINED;
040cd23242413a Boaz Harrosh   2007-08-16  231  	scsi_set_resid(SCpnt, scsi_bufflen(SCpnt));
^1da177e4c3f41 Linus Torvalds 2005-04-16  232  
^1da177e4c3f41 Linus Torvalds 2005-04-16  233  	/* setup scratch area
^1da177e4c3f41 Linus Torvalds 2005-04-16  234  	   SCp.ptr		: buffer pointer
^1da177e4c3f41 Linus Torvalds 2005-04-16  235  	   SCp.this_residual	: buffer length
^1da177e4c3f41 Linus Torvalds 2005-04-16  236  	   SCp.buffer		: next buffer
^1da177e4c3f41 Linus Torvalds 2005-04-16  237  	   SCp.buffers_residual : left buffers in list
^1da177e4c3f41 Linus Torvalds 2005-04-16  238  	   SCp.phase		: current state of the command */
040cd23242413a Boaz Harrosh   2007-08-16  239  	if (scsi_bufflen(SCpnt)) {
040cd23242413a Boaz Harrosh   2007-08-16  240  		SCpnt->SCp.buffer	    = scsi_sglist(SCpnt);
^1da177e4c3f41 Linus Torvalds 2005-04-16  241  		SCpnt->SCp.ptr		    = BUFFER_ADDR;
^1da177e4c3f41 Linus Torvalds 2005-04-16  242  		SCpnt->SCp.this_residual    = SCpnt->SCp.buffer->length;
040cd23242413a Boaz Harrosh   2007-08-16  243  		SCpnt->SCp.buffers_residual = scsi_sg_count(SCpnt) - 1;
^1da177e4c3f41 Linus Torvalds 2005-04-16  244  	} else {
040cd23242413a Boaz Harrosh   2007-08-16  245  		SCpnt->SCp.ptr		    = NULL;
040cd23242413a Boaz Harrosh   2007-08-16  246  		SCpnt->SCp.this_residual    = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  247  		SCpnt->SCp.buffer	    = NULL;
^1da177e4c3f41 Linus Torvalds 2005-04-16  248  		SCpnt->SCp.buffers_residual = 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  249  	}
^1da177e4c3f41 Linus Torvalds 2005-04-16  250  
^1da177e4c3f41 Linus Torvalds 2005-04-16  251  	if (nsphw_start_selection(SCpnt) == FALSE) {
^1da177e4c3f41 Linus Torvalds 2005-04-16  252  		nsp_dbg(NSP_DEBUG_QUEUECOMMAND, "selection fail");
^1da177e4c3f41 Linus Torvalds 2005-04-16  253  		SCpnt->result   = DID_BUS_BUSY << 16;
^1da177e4c3f41 Linus Torvalds 2005-04-16  254  		nsp_scsi_done(SCpnt);
^1da177e4c3f41 Linus Torvalds 2005-04-16  255  		return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  256  	}
^1da177e4c3f41 Linus Torvalds 2005-04-16  257  
^1da177e4c3f41 Linus Torvalds 2005-04-16  258  
^1da177e4c3f41 Linus Torvalds 2005-04-16  259  	//nsp_dbg(NSP_DEBUG_QUEUECOMMAND, "out");
^1da177e4c3f41 Linus Torvalds 2005-04-16  260  #ifdef NSP_DEBUG
^1da177e4c3f41 Linus Torvalds 2005-04-16  261  	data->CmdId++;
^1da177e4c3f41 Linus Torvalds 2005-04-16  262  #endif
^1da177e4c3f41 Linus Torvalds 2005-04-16  263  	return 0;
^1da177e4c3f41 Linus Torvalds 2005-04-16  264  }
^1da177e4c3f41 Linus Torvalds 2005-04-16  265  

:::::: The code at line 226 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux