On Thu, 2006-11-23 at 13:48 +0100, Henne wrote: > - volatile Scsi_Cmnd *input_Q; /* commands waiting to be started */ > - volatile Scsi_Cmnd *selecting; /* trying to select this command */ > - volatile Scsi_Cmnd *connected; /* currently connected command */ > - volatile Scsi_Cmnd *disconnected_Q;/* commands waiting for reconnect */ > + volatile struct scsi_cmnd *input_Q; > + /* commands waiting to be started */ > + volatile struct scsi_cmnd *selecting; > + /* trying to select this command */ > + volatile struct scsi_cmnd *connected; > + /* currently connected command */ > + volatile struct scsi_cmnd *disconnected_Q; This doesn't preserve the indentation of the original. Plus, I think if you lose the volatile then a lot of pointless casts like this one: > - tmp = (Scsi_Cmnd *) hostdata->input_Q; > + tmp = (struct scsi_cmnd *) hostdata->input_Q; Can be eliminated entirely (its sole job is to drop the volatile again). James - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
