Re: [PATCH v5 14/23] sg: split sg_read

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/8/19 9:50 AM, Douglas Gilbert wrote:
> As sg_read() is getting quite long, split out the v1 and v2
> processing into sg_rd_v1v2(). Rename sg_new_read() to
> sg_v3_receive() as the v3 interface is now older than the v4
> interface which is being added in a later patch.
> 
> Signed-off-by: Douglas Gilbert <dgilbert@xxxxxxxxxxxx>
> ---
>  drivers/scsi/sg.c | 273 +++++++++++++++++++++++-----------------------
>  1 file changed, 135 insertions(+), 138 deletions(-)
> 
Please use consistent naming.

Either 'sg_v3_receive', 'sg_v1v2_read' etc, or
'sg_receive_v3', 'sg_read_v1v2' etc.
And decide whether to use abbreviated or full names.
IE either sg_read_v1v2 or sg_rd_v1v2, but if the latter than
I would also prefer to have 'sg_rcv_v3'.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      Teamlead Storage & Networking
hare@xxxxxxx			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 247165 (AG München), GF: Felix Imendörffer



[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux