zhengbin, > We can init sshdr in sr_get_events, but there have many callers of > scsi_execute, scsi_execute_req, we have to troubleshoot all callers, > the simpler way is init sshdr in __scsi_execute. There aren't that many callers. I'd prefer to make sure that everybody is handling DRIVER_SENSE and scsi_sense_valid() correctly. Looks like we're generally OK, but please verify. Thanks! -- Martin K. Petersen Oracle Linux Engineering