Re: [PATCH] megaraid_sas: unique names for MSIx vectors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Chandrakanth Patil <chandrakanth.patil@xxxxxxxxxxxx>
Subject: Re: [PATCH] megaraid_sas: unique names for MSIx vectors
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Mon, 30 Sep 2019 23:43:38 -0400
Cc: linux-scsi@xxxxxxxxxxxxxxx, kashyap.desai@xxxxxxxxxxxx, sumit.saxena@xxxxxxxxxxxx, kiran-kumar.kasturi@xxxxxxxxxxxx, sankar.patra@xxxxxxxxxxxx, sasikumar.pc@xxxxxxxxxxxx, shivasharan.srikanteshwara@xxxxxxxxxxxx, anand.lodnoor@xxxxxxxxxxxx
In-reply-to: <20190913065515.22493-1-chandrakanth.patil@broadcom.com> (Chandrakanth Patil's message of "Fri, 13 Sep 2019 12:25:15 +0530")
Organization: Oracle Corporation
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux)

Chandrakanth,

> +#define MEGASAS_MSIX_NAME_LEN			16

[...]

> +		snprintf(instance->irq_context[i].name, MEGASAS_MSIX_NAME_LEN, "%s%d-msix%d",
> +			"megasas", instance->host->host_no, i);

Seems like MEGASAS_MSIX_NAME_LEN is too small given that naming scheme?

Also, please use %u.

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH] megaraid_sas: unique names for MSIx vectors
  - From: Chandrakanth Patil

Prev by Date: Re: [PATCH] scsi: ignore a failure to synchronize cache due to lack of authorization
Next by Date: Re: [PATCH] zfcp: fix reaction on bit error theshold notification with adapter close
Previous by thread: [PATCH] megaraid_sas: unique names for MSIx vectors
Next by thread: [PATCH 00/13] Enhancements w.r.t to diag buffer and few bug fixes
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]

Powered by Linux