On 9/26/19 9:46 AM, Daniel Wagner wrote: > Commit 88263208dd23 ("scsi: qla2xxx: Complain if sp->done() is not > called from the completion path") introduced the WARN_ON_ONCE in > qla2x00_status_cont_entry(). The assumption was that there is only one > status continuations element. According to the firmware documentation > it is possible that multiple status continuations are emitted by the > firmware. > > Cc: Bart Van Assche <bvanassche@xxxxxxx> > Signed-off-by: Daniel Wagner <dwagner@xxxxxxx> > --- > drivers/scsi/qla2xxx/qla_isr.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_isr.c b/drivers/scsi/qla2xxx/qla_isr.c > index 4c26630c1c3e..009fd5a33fcd 100644 > --- a/drivers/scsi/qla2xxx/qla_isr.c > +++ b/drivers/scsi/qla2xxx/qla_isr.c > @@ -2837,8 +2837,6 @@ qla2x00_status_cont_entry(struct rsp_que *rsp, sts_cont_entry_t *pkt) > if (sense_len == 0) { > rsp->status_srb = NULL; > sp->done(sp, cp->result); > - } else { > - WARN_ON_ONCE(true); > } > } > > Not that I can speak for firmware documentation, but: Reviewed-by: Hannes Reinecke <hare@xxxxxxxx> Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@xxxxxxx +49 911 74053 688 SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 247165 (AG München), GF: Felix Imendörffer