Hi Saurav, On Tue, Sep 24, 2019 at 09:11:38AM +0200, Daniel Wagner wrote: > On Tue, Sep 24, 2019 at 06:08:09AM +0000, Saurav Kashyap wrote: > > > +static void qedf_get_host_port_id(struct Scsi_Host *shost) { > > > + struct fc_lport *lport = shost_priv(shost); > > > + > > > + fc_host_port_id(shost) = lport->port_id; } > > > > Minor stuff, the closing brace should be in next line. Please submit v2. > > Oops, sorry about that. The patch I sent out had the closing brace on a new line: https://lore.kernel.org/linux-scsi/20190923103738.67749-1-dwagner@xxxxxxx/ Now I am a bit confused how I screwed it up. Anyway, I'll send it out again after with hexdump there is not a special ASCII character hidden :) Thanks, Daniel