On Mon, Sep 16, 2019 at 10:47 PM Denis Efremov <efremov@xxxxxxxxx> wrote:
>
> Replace the magic constant (6) with define PCI_STD_NUM_BARS representing
> the number of PCI BARs.
>
> Cc: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>
> Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxx>
> Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>
Looks fine, thanks!
Acked-by: Jack Wang <jinpu.wang@xxxxxxxxxxxxxxx>
> ---
> drivers/scsi/pm8001/pm8001_hwi.c | 2 +-
> drivers/scsi/pm8001/pm8001_init.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/pm8001/pm8001_hwi.c b/drivers/scsi/pm8001/pm8001_hwi.c
> index 68a8217032d0..1a3661d6be06 100644
> --- a/drivers/scsi/pm8001/pm8001_hwi.c
> +++ b/drivers/scsi/pm8001/pm8001_hwi.c
> @@ -1186,7 +1186,7 @@ static void pm8001_hw_chip_rst(struct pm8001_hba_info *pm8001_ha)
> void pm8001_chip_iounmap(struct pm8001_hba_info *pm8001_ha)
> {
> s8 bar, logical = 0;
> - for (bar = 0; bar < 6; bar++) {
> + for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {
> /*
> ** logical BARs for SPC:
> ** bar 0 and 1 - logical BAR0
> diff --git a/drivers/scsi/pm8001/pm8001_init.c b/drivers/scsi/pm8001/pm8001_init.c
> index 3374f553c617..aca913490eb5 100644
> --- a/drivers/scsi/pm8001/pm8001_init.c
> +++ b/drivers/scsi/pm8001/pm8001_init.c
> @@ -401,7 +401,7 @@ static int pm8001_ioremap(struct pm8001_hba_info *pm8001_ha)
>
> pdev = pm8001_ha->pdev;
> /* map pci mem (PMC pci base 0-3)*/
> - for (bar = 0; bar < 6; bar++) {
> + for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) {
> /*
> ** logical BARs for SPC:
> ** bar 0 and 1 - logical BAR0
> --
> 2.21.0
>
--
Jack Wang
Linux Kernel Developer
Platform Engineering Compute (IONOS Cloud)
